Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DB extension collapse #24315

Merged
merged 1 commit into from
Jun 8, 2023
Merged

fix: DB extension collapse #24315

merged 1 commit into from
Jun 8, 2023

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Jun 7, 2023

SUMMARY

Fix the caret in the DB extension extra option, making it expand/collapse the panel.

For some reason the type icon is only present in the CollapsibleType enum in antd 4.24.0 (we're using 4.10.3), but it works correctly as seen in the screencasts below.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

before.mov

After:

drawer_after.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #24315 (f372ce4) into master (5d3c1d2) will not change coverage.
The diff coverage is 0.00%.

❗ Current head f372ce4 differs from pull request most recent head 5943f92. Consider uploading reports for the commit 5943f92 to get more accurate results

@@           Coverage Diff           @@
##           master   #24315   +/-   ##
=======================================
  Coverage   68.33%   68.33%           
=======================================
  Files        1957     1957           
  Lines       75627    75627           
  Branches     8225     8225           
=======================================
  Hits        51679    51679           
  Misses      21835    21835           
  Partials     2113     2113           
Flag Coverage Δ
javascript 54.76% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../features/databases/DatabaseModal/ExtraOptions.tsx 64.70% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@betodealmeida betodealmeida merged commit bf91ed9 into master Jun 8, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the fix_extension_collapse branch March 26, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants